Template talk:Talk header: Difference between revisions
→Is there a clear summary of the proposal / intended change?: That should be a separate request. |
→Testing progress: Sandbox code removed for higher priority issue. |
||
Line 203: | Line 203: | ||
Just to chime in regarding the cutoff for rounding ClueBot: it appears the code is using 24 hours. Only [[User:Novem Linguae]] suggested this. I have suggested 72 hours instead. Nobody has objected, but also, your response so far has been "it's incredibly easy to change it to any figure that comes out of consensus here" which is nice, but also kind of ignores my message. How about doing that which is so incredibly easy, and setting the number to 72 before finalizing testing, and then waiting for consensus to change it? [[User:CapnZapp|CapnZapp]] ([[User talk:CapnZapp|talk]]) 21:27, 4 April 2024 (UTC) |
Just to chime in regarding the cutoff for rounding ClueBot: it appears the code is using 24 hours. Only [[User:Novem Linguae]] suggested this. I have suggested 72 hours instead. Nobody has objected, but also, your response so far has been "it's incredibly easy to change it to any figure that comes out of consensus here" which is nice, but also kind of ignores my message. How about doing that which is so incredibly easy, and setting the number to 72 before finalizing testing, and then waiting for consensus to change it? [[User:CapnZapp|CapnZapp]] ([[User talk:CapnZapp|talk]]) 21:27, 4 April 2024 (UTC) |
||
'''Note:''' the test code in the sandbox for adding this functionality has been removed in order to attend to a more important issue (see {{slink||Broken case}} below). The change will need to be re-added and retested in the sandbox. before moving ahead. [[User:Mathglot|Mathglot]] ([[User talk:Mathglot|talk]]) 06:15, 14 April 2024 (UTC) |
|||
== Broken case == |
== Broken case == |
Revision as of 06:16, 14 April 2024
This is the talk page for discussing improvements to the Talk header template. |
|
Archives: Index, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11Auto-archiving period: 60 days ![]() |
![]() | Template:Talk header is permanently protected from editing because it is a heavily used or highly visible template. Substantial changes should first be proposed and discussed here on this page. If the proposal is uncontroversial or has been discussed and is supported by consensus, editors may use {{edit template-protected}} to notify an administrator or template editor to make the requested edit. Usually, any contributor may edit the template's documentation to add usage notes or categories.
Any contributor may edit the template's sandbox. Functionality of the template can be checked using test cases. |
![]() | This page is only for discussions about the Wikipedia page Template:Talk header. To discuss an article, please use that article's talk page. To ask for help with using and editing Wikipedia, use our Teahouse. Alternatively, see our FAQ. | This page is not meant for general questions, nor discussions about specific articles.
![]() | This template was nominated for deletion. Please review the prior discussions if you are considering re-nomination:
|
![]() | This template was considered for merging with Template:Vital article on 17 May 2023. The result of the discussion was "Incorporate {{Vital article}}'s information into the {{WikiProject banner shell}} area". |
Template-protected edit request on 17 May 2023
![]() | This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Update the TfD link to Wikipedia:Templates for discussion/Log/2023 May 17 Aaron Liu (talk) 17:49, 17 May 2023 (UTC)
Done {{u|Sdkb}} talk 17:52, 17 May 2023 (UTC)
- I've removed it. This discussion has had massive participation and I don't think we need further input from editors. It could have been closed after a week and should not have been relisted — Martin (MSGJ · talk) 15:31, 18 May 2023 (UTC)
- I concur with all of that, MSGJ. {{u|Sdkb}} talk 17:16, 18 May 2023 (UTC)
Proposal to drop archiving params
This is a proposal to drop the four archiving params (a.k.a. bot-notice params) |bot=
, |age=
, |units=
and |minthreadsleft=
. We can get the same information from the MiszaBot/config with more accuracy without these four params, and at the same time, generate a bot notice for all the pages that have a Talk page header but currently lack these params.
Up till now, the four archive-related params have been responsible for the bot notice seen optionally below the archive search box, and still are in override mode. However, they only control the notice, and do not affect whether or how archiving is actually carried out on the page, which is instead specified by template User:MiszaBot/config. In fact, the template bot-notice params and the MiszaBot config often get out of sync, leading to a misleading notice displayed in the Talk page header.
I've just released a new version of Template:Talk header which generates the bot notice below the search box automatically without parameters; any page having a MiszaBot/config and lacking the bot-notice params will now show the notice. However, if both a MiszaBot/config *and* bot notice-params are present, then the latter act as an override, and in many cases this means that the correct values determined by the new template are overridden by incorrect or out-of-sync user-supplied bot notice params. Pages that formerly had no bot notice, now have them if they have archiving configured; for example, see Talk:2017 or Talk:Traditional marriage. lots more examples here.
I don't currently see a reason to keep the four bot-notice params |bot=
, |age=
, |units=
and |minthreadsleft=
, and I think they should all be deleted; 1) because they are no longer needed, and 2) in order to stop generating misleading bot notices. We should just let the template calculate the notice. Perhaps there might be a reason to sometimes suppress the bot notice; in that case we should replace the four params with a new one: |bot-notice=none
. Another reason to keep the four params, might be if there are other archiving schemes currently in use that employ some configuration other than MiszaBot/config or Cluebot III's config; in that case, either the template should be upgraded to recognize the other schemes, or we should just keep the params for those cases. Feedback sought and appreciated. Mathglot (talk) 04:17, 29 February 2024 (UTC) updated by Mathglot (talk) 08:54, 29 February 2024 (UTC)
- This proposal is linked from WP:VPR with an expiration 3 weeks from now, to allow sufficient time for this to air. Mathglot (talk) 10:40, 3 March 2024 (UTC)
What about Template:Archives
@Mathglot: Would it be worthwhile to add this functionality to Template:Archives as well? Tollens (talk) 23:30, 29 February 2024 (UTC)
- Tollens, I had just noticed that template during the updates for this one, and had the same thought. That said, let's give this one a chance to air, and if there's no strong objections to it here, then I think your idea makes good sense as a follow-on change. P.S. no ping needed; I'm subscribed. Mathglot (talk) 23:47, 29 February 2024 (UTC)
Seems fine so long as it works as advertised for both bot archival templates. Automates a step that is otherwise easy to forget when archiving needs to be tweaked and no real downsides. I presume if there were a case where the params had been deliberately kept blank for some reason, the auto-population would have already drawn a complaint. 184.152.68.190 (talk) 03:36, 1 March 2024 (UTC)
Support - yes, if you want to contribute by writing a script/bot to get the information straight from the source, letting us bypass a manual element that mostly introduces a source of errors, this is of course very welcome! CapnZapp (talk) 12:00, 1 March 2024 (UTC)
- I have something in the sandbox there, but it's not working yet. I basically got lost in a twisty little maze of curlies, all alike, and trying to fight my way out. Not sure when or if I'll get back to it, but it should point the way if someone else wants to have a look. At least the new code is comprehensible due to indentation, but I'm probably missing a curly higher up someplace. No new script needed, by the way; it calls the same parsing template developed for the solution here. Currently, it's a subtemplate of Template:Talk header, but if we use it from two places, maybe it should be spun off into its own root page. Mathglot (talk) 21:54, 1 March 2024 (UTC)
- I'm happy to give it a go – what exactly was the issue? It looks like a bad parameter was being used for the minimum number of threads to keep, but other than that I can't see anything wrong. Curlies all seem to match up far as I can tell. Tollens (talk) 22:31, 1 March 2024 (UTC)
- Made a couple other tweaks. As an aside, do we want to move the information about the specific archival bot and minimum threads to a tooltip as was done with Template:Talk header? I know I've used Template:Archives with only the age parameter on my user talk for quite some time and would prefer to keep it appearing that way or similar rather than having the other information be forced to display. Tollens (talk) 23:20, 1 March 2024 (UTC)
- Thanks; as long as it's just in the sandbox, you can do pretty much what you like. I'll have to go look again to remind myself what the problem was. But a discussion section should probably be started there, linking/summarizing this one, to explain what it is that is being discussed. That box has had a different presentation for a long time, and any move of info to a tooltip should probably get consensus there, imho. Or now that I think about it, as it concerns two templates (maybe more?) perhaps at a more centralized venue, like Help talk:Archiving a talk page. Mathglot (talk) 02:43, 2 March 2024 (UTC)
- Noticed your changes—thanks for that—and added a couple more. Wanted to add some test cases, but if this holds up, and there are no objections from regulars at the Talk page there, I think this would be a beneficial change, and keep the two templates relatively in sync. The same test cases as found at Template:Talk header/testcases4#B. Testing with the subtemplate but tested in situ should work here as well. Mathglot (talk) 12:00, 2 March 2024 (UTC)
- Made a couple other tweaks. As an aside, do we want to move the information about the specific archival bot and minimum threads to a tooltip as was done with Template:Talk header? I know I've used Template:Archives with only the age parameter on my user talk for quite some time and would prefer to keep it appearing that way or similar rather than having the other information be forced to display. Tollens (talk) 23:20, 1 March 2024 (UTC)
- I'm happy to give it a go – what exactly was the issue? It looks like a bad parameter was being used for the minimum number of threads to keep, but other than that I can't see anything wrong. Curlies all seem to match up far as I can tell. Tollens (talk) 22:31, 1 March 2024 (UTC)
Proposal to drop archiving params – break
How about ClueBot III? Graham87 (talk) 04:54, 29 February 2024 (UTC)
- Thanks, wasn't aware it used a different config; it can be added. Do you know of any others? Mathglot (talk) 04:57, 29 February 2024 (UTC)
- Graham87, it supports Cluebot_III configs now; any other bots you know of that need to be supported? Mathglot (talk) 08:34, 29 February 2024 (UTC)
- @Mathglot: Nope, that's it. Your ping didn't work by the way, probably because of the shuffling around of messages. While I'm thinking about it I support removal of the now-redundant parameters; it means I won't have to make occasional updates of archiving bot names like this (a previous bot run caught many of them, but not everything). Graham87 (talk) 09:21, 29 February 2024 (UTC)
- Graham87, it supports Cluebot_III configs now; any other bots you know of that need to be supported? Mathglot (talk) 08:34, 29 February 2024 (UTC)
This sounds like a solid improvement. It's too bad we didn't initially think of it when merging in auto archive notice back in 2021, as it may generate a few complaints about watchlist clutter, but I think it'll be worth it to remove the duplicative information, so I support. Sdkb talk 05:15, 29 February 2024 (UTC)
I think there is value in displaying such data - but they'd need to be the actual archive data and thus be displayed from User:MiszaBot/config. So yeah, remove 'em from this template. Jo-Jo Eumerus (talk) 07:51, 29 February 2024 (UTC)
- Yes, it is displaying actual archive data pulled from the config. Currently, either MiszaBot, or Cluebot, whichever one it finds on the page. Mathglot (talk) 08:51, 29 February 2024 (UTC)
how and when to drop the bot notice params
This was supposed to run three weeks according to the notice pointing here from WP:VPT, but for some reason, the section there got archived, even with a {{DNAU}} in place. But it was there for over two weeks, and no objection was registered. Here's what it would take, imho, to drop the four bot notice params from the {{Talk page header}} template:
- make sure interested parties here are good to go with this; handle any concerns
- remove params
|archive_bot=
,|archive_age=
,|archive_units=
,|minthreadsleft=
and their aliases from the template code, except for the unknown parameter invocation at the bottom. The effect will be that Talk pages currently containing these params will begin displaying data directly from the config params (if any) and stop overriding the actual configured values with the values given in the params. Pages having no archiving will stop displaying false notices. The parameters will still exist, but have no effect. - update the doc, removing the four from the main Parameters section but adding a temporary deprecated notice for some period (a year?)
- at some point (no hurry), request a bot to remove deprecated params from transclusions of {{Talk header}}; maybe WP:AWB can do this with an appropriate regex.
- Once the bot is complete (do Advanced search to make sure), remove the params from the unknown parameter invocation at the bottom.
- Remove the doc page deprecated params notice.
The first three should be done whenever we are ready, which I think is now; unless there is some objection. The last three are optional, but it makes sense to do them, and will declutter the template code and the doc. The section above on § minimum number of sections archived, and in general, anything regarding what wording to use in the notice is completely independent from dropping the bot params, and the two processes may continue independently without taking the other into consideration. Probably subsections 3 and 4 should be broken out into a new, top-level discussion section about new wording, because they aren't really related to the dynamic bot notice topic at all. (edit conflict) Mathglot (talk) 03:01, 20 March 2024 (UTC)
- Two subsections moved to § New and modified bot notice wording proposals. Mathglot (talk) 04:21, 20 March 2024 (UTC)
- FWIW, Wikipedia:Village_pump_(proposals)#Feedback_sought_for_proposal_to_drop_archival_bot_notice_params_from_Template:Talk_header is there when I looked just now. CapnZapp (talk) 13:59, 29 March 2024 (UTC)
- Hi Capn, yes, I see it; not sure what you meant to say about the VPR thread.
- As far as the steps above, it's been a month since the auto-generation of the bot notice was installed on 29 Feb., and I haven't seen any response, so that's a good sign that probably nobody even noticed, and at a minimum, we didn't break anything because that would've caused howls right away. I think we can move on to step 2, at least, when someone is available to do it. I'll be away starting in a few days and I don't want to start something now that might break and require attention just when I'll have no time for it. I'll have wifi occasionally for questions while away, but I wouldn't attempt template coding from my phone. Of course, there is nothing stopping anyone else from updating it who feels like doing so. Steps 4 & 5 can even be ignored forever; the downside is that there would be stale code in the template that does nothing, which is inelegant and makes it harder for other template editors to maintain it or add new functionality, so it's still a good idea to do those steps at some point, if possible. Mathglot (talk) 00:01, 30 March 2024 (UTC)
- FWIW, Wikipedia:Village_pump_(proposals)#Feedback_sought_for_proposal_to_drop_archival_bot_notice_params_from_Template:Talk_header is there when I looked just now. CapnZapp (talk) 13:59, 29 March 2024 (UTC)
Is there a clear summary of the proposal / intended change?
I don't really understand what is being proposed here, what has been implemented so far, what will be implemented in the future, etc.
I would strongly recommend that this template:
- Should not show the name of the archive bot by default, or ideally not at all. That information is a distracting reader-irrelevant internal implementation detail. At the very most, mention of the bot's name should be opt-in.
- Should show archive time in units rounded so that the number is a small value. That is, we should show "3 months" instead of "90 days", "2 years" instead of "730 days", etc.
- Should skip describing the min threads to archive, min threads left, max archive size, etc. Nobody who is just reading the talk page does or should care about these
In general, any very widely used talk page template should strongly prioritize eliminating, hiding, and minimizing the space use and distraction of non-essential information. Adding gratuitous configuration metadata is a reader hostile regression. –jacobolus (t) 22:06, 11 April 2024 (UTC)
- All information aside from archive time on this one is only located in a tooltip (you can see an example on this page's header if you hover over "Auto-archiving period"), so in this case, unlike Template:Archives, I don't see the harm here because it's only visible when you're looking for it. I agree completely with your second point. Tollens (talk) 22:16, 11 April 2024 (UTC)
- Got it. I didn't realize it was a tooltip. (The tooltip seems fine!) I was coming here after seeing the change to {{archives}}, where the bot name is now presented by default on every talk page using that template. –jacobolus (t) 22:22, 11 April 2024 (UTC)
- Agree with your 2nd point here, but that is another proposal that should start off a new, top- level section as a discussion or edit request. Imho, it’s not a good idea to keep piggy-backing on additional requests onto an earlier request, which isn’t completed yet, especially in the case of a template with such high usage and visibility. We need to let this one complete, without additional complications. That doesn’t mean you can’t start another section now as it can be discussed and implemented completely independently from the current request. Does that help? Mathglot (talk) 00:28, 12 April 2024 (UTC)
New and modified bot notice wording proposals
Convert Cluebot hours to days?
One thing that becomes evident with this change, is the somewhat less friendly units used by Cluebot; how long is 2880 hours, anyway? This is not a big deal, but as long as we are talking about these changes, it would be an easy fix to display the hourly total as days (approx. days, decimal days, rounded days; preference?) if it exceeds some threshold number of hours. I think after 96 hours, I pretty much lose it, not sure about anybody else. If you want to see some live examples, check out the bot notice at any of these Talk pages which all use Cluebot: Talk:The Exorcist, Talk:List of colors, Talk:Toronto, Talk:Switzerland, Talk:Macedonia. We could display days in the notice, and exact hours in the Tooltip, if desired. Mathglot (talk) 08:48, 29 February 2024 (UTC)
- I'd suggest rounding anything over 23 hours. I can convert 36, 48, 72 hours, etc. in my head, but it takes some thought. Would rather see that in 1.5 days, 2 days, 3 days format. –Novem Linguae (talk) 10:02, 29 February 2024 (UTC)
- Sure, this sounds fine. Even if it involves some loss of precision, I have a hard time conceiving of any situation where it would matter that a talk pages be archived at a large but precise number of hours. Sdkb talk 14:51, 29 February 2024 (UTC)
- Especially as there's no way to know what kind of delay might be involved before the bot gets around to visiting the page. Mathglot (talk) 23:48, 29 February 2024 (UTC)
- Delays should not be taken into account. If a page claims archiving will happen after 6 or 18 or 30 or 60 hours, we should probably say that even though the actual arching cadency is just once a day... Cheers CapnZapp (talk) 14:35, 1 March 2024 (UTC)
Done. A description of this new functionality can be found at § Archive bot notice; please have a look and adjust as needed. Mathglot (talk) 07:02, 1 March 2024 (UTC)
- I would not round any hour figure lower than 72. Starting to round already at >23 feels unnecessarily aggressive. CapnZapp (talk) 14:32, 1 March 2024 (UTC)
- No worries; it's incredibly easy to change it to any figure that comes out of consensus here. Mathglot (talk) 21:22, 1 March 2024 (UTC)
For archiving bots that use hours as the default units, they are converted to days, rounded to the nearest half-day
This I take to mean ANY number is rounded to a multiple of 12 (half a day). I would suggest a more conservative start. Do not round any hours-number lower than 72 for starters, then let consensus drive rounding of lower numbers. The other way round assumes we will revisit the subject later. I think now is the only time you will hear voices to avoid rounding smaller numbers, so please consider this to be the consensus you'll get. CapnZapp (talk) 09:11, 2 March 2024 (UTC)- Thanks for pointing that out; I neglected to mention the > 23 threshold, so I tweaked the doc, which should be accurate now; sorry for the confusion. As far as what the threshold should be, 72 sounds fine, so does 96, so does 24; it's easily changeable and I have no strong preference myself. Mathglot (talk) 10:00, 2 March 2024 (UTC)
- If my voice is the only voice with an opinion: start with 72 and change it if somebody asks for it. Not the other way round, partly because doing it that way in effect willfully ignores suggestions you are getting now. Why can't suggestions now hold equal weight to those that you (probably won't) get later? Thanks CapnZapp (talk) 14:04, 29 March 2024 (UTC)
- Any multiple of 24 hours should definitely be presented as X days; this is significantly more likely to be the intention than hours per se. Odd multiples of 12 hours should generally be presented as X.5 days, though maybe 12h or 36h can be left as exceptions. If someone has some weird value like 20 or 50 hours then maybe show it as hours. –jacobolus (t) 22:32, 11 April 2024 (UTC)
- If my voice is the only voice with an opinion: start with 72 and change it if somebody asks for it. Not the other way round, partly because doing it that way in effect willfully ignores suggestions you are getting now. Why can't suggestions now hold equal weight to those that you (probably won't) get later? Thanks CapnZapp (talk) 14:04, 29 March 2024 (UTC)
- Thanks for pointing that out; I neglected to mention the > 23 threshold, so I tweaked the doc, which should be accurate now; sorry for the confusion. As far as what the threshold should be, 72 sounds fine, so does 96, so does 24; it's easily changeable and I have no strong preference myself. Mathglot (talk) 10:00, 2 March 2024 (UTC)
- I would not round any hour figure lower than 72. Starting to round already at >23 feels unnecessarily aggressive. CapnZapp (talk) 14:32, 1 March 2024 (UTC)
- Especially as there's no way to know what kind of delay might be involved before the bot gets around to visiting the page. Mathglot (talk) 23:48, 29 February 2024 (UTC)
minimum number of sections archived
Related to this, there is one nugget of information you can configure the archive bots with, but wasn't possible to convey through the templates:
If you tell the bots to not archive until, say, 2 sections are eligible, then its possible for users to not understand why the bot isn't archiving.
Say there are 5 talk sections. All are older than the number of days specified. But the settings say "keep at least four sections and only archive two or more sections at a time." This means no archiving is done for now, since you need a sixth new talk discussion in order to archive two of the stale discussions and still leave four on the page.
(PS. Configuring the bot to keep 4 sections is very useful since the table of content is per default only generated on pages with four sections. Configuring the bot to only archive two sections at a time is relatively useful to avoid cluttering the history page with lots of archival edits, which can come across as the bot being "too aggressive" in its cleaning)
Proposal: tweak this new wondrous automatic display of the actual bot settings to also tell the user if the bot will only archive two or more sections at a time. Specifically when |minthreadstoarchive=2
(or more). Cheers CapnZapp (talk) 12:09, 1 March 2024 (UTC)
|minthreadstoarchive=
is currently displayed in the tooltip (along with the specific bot that does the archiving). It's not ideal, but when we designed the merge, keeping the display very concise was a top concern (for good reason, given the tendency for talk page banner bloat), so that's what we went with. Thinking in terms of a talk page user, I can see why it might be useful to know the auto-archiving period, but it's harder to envision reasons why it would be helpful to know the minthreadstoarchive or the specific bot that does the archiving. Sdkb talk 20:30, 1 March 2024 (UTC)- Capn, it would be a fairly easy upgrade to add what you are suggesting, but as Sdkb points out, it's already there in the tooltip, and I think the trade-off design of lean-and-mean visible part, and the rest of it in a tooltip was a good decision. Other than tooltips are not easily visible from mobile, not sure if there are other accessibility issues with tooltips; it had occurred to me that along with this change one might add alt text for screen readers, but I didn't want to overload the proposal, at least initially, with too much stuff. But it's something to consider, moving forward. Mathglot (talk) 21:31, 1 March 2024 (UTC)
- Cap'n, since you mentioned wondrous—I also think it's pretty cool—I wanted to spread the credit where it's due. While in theory this could have been implemented earlier through use of a set of complex regular expressions, that would've been difficult to develop, test, and maintain, and might've been fragile. What really made the archival config auto-detection feasible here was the upgrade to Module:Template parameter value developed by Aidan9382, which in turn enabled construction of {{HasTemplate}}. There is still some regex code in the archive bot parser here, but it's straightforward and not the tangled mess it would've been had we not had access to this upgrade. While the Module upgrade was in progress, I didn't even imagine it being used here (had something else in mind) but after it was done, a little light turned on and I realized it was now possible, and not even difficult, to add the config detection and parsing. So that led in a pretty direct line to the changes here. I think the Module upgrade will have beneficial knock-on effects elsewhere, so spread a little love in Aidan's direction. Sdkb will recognize one opportunity in the somewhat clunky WikiProject detection in {{find sources}} for domain selection, and I predict others will come to light. Mathglot (talk) 22:18, 1 March 2024 (UTC)
- Okay at first User:Sdkb (and User:Mathglot), I thought you meant this functionality had been recently added. But looking at an example page Talk:Gravity (2013 film) I don't see it. The tooltip states "Discussions with timestamps are automatically archived by lowercase sigmabot III after 120 days of inactivity when more than 5 threads are present." There is no mention the bot will archive only when more than 1 thread is eligible; for this page, the param is set to
|minthreadstoarchive=2
So a reader can be left completely bewildered and not understand why the bot "isn't working" when it isn't archiving the oldest section once a sixth discussion is started, when in fact, it IS working: to keep down the number of archival edits; it will only step in once a seventh discussion is started, if it can then archive two discussions in one sweep. It's just the information that is inadequate. This is the same as when the talk header template first was reworked - support for every param except|minthreadstoarchive=
. Unless there's something strange going on and I don't see what you guys are seeing? (I'm using legacy Vector if that matters) Cheers CapnZapp (talk) 09:27, 2 March 2024 (UTC)- I see what you are saying, and all I can say is, the proposal that is the object of this discussion was, at least at first anyway, solely about replicating existing wording from whatever the template was doing before, and just making sure to get accurate values directly from the config and not from template parameters which often go out of sync. If the bot notice didn't say anything about minthreadstoarchive before, then it won't say anything about it after the change, either. I see your point about reader confusion, and for whatever reason, there hasn't been a decision to address that in the bot notice previously, so we aren't addressing it either, in order to stick to previous behavior as much as possible.
- My suggestion would be simply to start a new top-level discussion proposing your change. Then, regardless whether the bot config-detection function is kept or not kept, your proposal about minthreadstoarchive would stand on its own and could succeed independently. Or, you could just try a bold change and see if it sticks. That's my take; I wonder what Sdkb will say about this. Mathglot (talk) 09:50, 2 March 2024 (UTC)
- Given that this is a TE-protected template with 500k+ transclusions, I wouldn't recommend bold editing. I'd be interested to see a concrete proposal (i.e. a mockup of the design you'd like) for displaying
|minthreadstoarchive=
, but as I said above, I'll be skeptical of its value (and more so the more prominent the display). Sdkb talk 16:29, 2 March 2024 (UTC)
- Given that this is a TE-protected template with 500k+ transclusions, I wouldn't recommend bold editing. I'd be interested to see a concrete proposal (i.e. a mockup of the design you'd like) for displaying
- Okay at first User:Sdkb (and User:Mathglot), I thought you meant this functionality had been recently added. But looking at an example page Talk:Gravity (2013 film) I don't see it. The tooltip states "Discussions with timestamps are automatically archived by lowercase sigmabot III after 120 days of inactivity when more than 5 threads are present." There is no mention the bot will archive only when more than 1 thread is eligible; for this page, the param is set to
You are claiming |minthreadstoarchive=
is currently displayed in the tooltip. I don't see it. I am not asking for this parameter to appear in the template. Just the tooltip text. I don't see why this could be controversial or why I need to start a new discussion or create a mockup? (Unless you mean simple wording along the lines of, still using Gravity as my example; "Discussions with timestamps are automatically archived by lowercase sigmabot III after 120 days of inactivity when more than 5 threads are present if more than 1 thread is eligible for archiving.") I'm simply thinking that since you're already editing the relevant code and you are the editors with the relevant knowledge (if you can extract the other params you can extract this one), why not suggest fixing this once and for all... CapnZapp (talk) 16:26, 3 March 2024 (UTC)
- @CapnZapp, if you go to a page like Talk:Algeria and hover your cursor over the text that says "Auto-archiving period", do you see the tooltip that reads
Discussions with timestamps are automatically archived by Lowercase sigmabot III after 90 days of inactivity when more than 4 threads are present
? That's what we're referring to. Cheers, Sdkb talk 00:50, 4 March 2024 (UTC) - Interesting; regarding Gravity: when I hover over Talk:Gravity's bot notice, I see it mentioning 365 days of inactivity and 10 threads; is that not what you see? The config hasn't been edited since January 10, but it was 180/none before that. Did you mean a different page? Mathglot (talk) 04:47, 4 March 2024 (UTC)
- I think CapnZapp is referring to a completely different thing than Mathglot and Sdkb here. There are two different parameters that relate to a number of threads – one (the one currently displayed) is for the number of threads which have to remain on the page after archiving (for example, if this parameter was 2 and there were 5 threads on the page, all of them old enough to archive, only 3 threads would be archived). The other one, which I think CapnZapp is referring to, is for the minimum number of threads that are allowed to be archived with a single edit by the bot (as another example, if that parameter was 2 and there was exactly one thread old enough to archive, the bot would not archive it at all, but once there were 2 or more eligible threads the bot would archive them all). Tollens (talk) 10:07, 4 March 2024 (UTC)
- Thanks for that clarification. Yes, agreed; but if the previous incarnation did not address that, should we be doing so? On the + side, strike while the iron is hot; on the - side, just trying to reproduce the original bot notice, which presumably had consensus previously (even if silent), without any significant changes, but more accurately. To the extent that a proposal represents a change to previous behavior, is this thread the right place to deal with it? I can see both views, but I wonder, given the visibility of the template, if additional changes to a highly visible template would require additional consensus? I don't know the answer to that question. Mathglot (talk) 10:39, 4 March 2024 (UTC)
- Sdkb I see it. I also see that the bot instructions for that particular revision has no
|minthreadstoarchive=
parameter set. CapnZapp (talk) 16:03, 4 March 2024 (UTC) - Tollens I am indeed referring to
|minthreadstoarchive=
and not merely|minthreadsleft=
which Talk header have had support for a while now. I think I have been consistently using minthreadstoarchive in my request but feel free to point out if I have accidentally mentioned a different parameter. CapnZapp (talk) 16:07, 4 March 2024 (UTC)- I agree that you've been using the correct parameter name – just trying to clear up the apparent confusion. Tollens (talk) 17:37, 4 March 2024 (UTC)
- So, if it uses both, how would you word that? Mathglot (talk) 20:33, 4 March 2024 (UTC)
- I think that was what CapnZapp meant by their example:
"Discussions with timestamps are automatically archived by lowercase sigmabot III after 120 days of inactivity when more than 5 threads are present if more than 1 thread is eligible for archiving."
(emphasis mine). Tollens (talk) 21:02, 4 March 2024 (UTC)
- I think that was what CapnZapp meant by their example:
- So, if it uses both, how would you word that? Mathglot (talk) 20:33, 4 March 2024 (UTC)
- I agree that you've been using the correct parameter name – just trying to clear up the apparent confusion. Tollens (talk) 17:37, 4 March 2024 (UTC)
- Mathglot: seeing that there's even confusion about which parameter we're discussing let me first ask you -respectfully- to make absolutely certain you understand the request I am making (instead of the request you might think I am making). To be clear, I am not asking for any visual change of the talk header template (and related templates). Only a more informative tooltip. Your caution to me suggests you might still think I'm asking for a more intrusive change than I am actually asking for. I honestly don't feel I need to make mockups - the template's appearance will remain unchanged. I honestly don't see why we would need a whole new round of consensus - again, it's only the tooltip that in a minority of cases would convey a little bit more information. Using Gravity movie as my example, if a page's bot instructions contain
|minthreadstoarchive=2
I would like the tooltip to say something along the lines of "...if more than 1 thread is eligible for archiving". As stated previously! I cannot do more than make sure I am using the right parameter name. I cannot help if people read that as referring to other parameters? Again, if y'all have any advice on how I can be more clear please advise - I thought I was crystal clear but apparently not so? CapnZapp (talk) 16:22, 4 March 2024 (UTC)- I'd support just making this change. I don't think anyone will be upset by (or, for that matter, notice) a change that's only inside a tooltip. Tollens (talk) 17:39, 4 March 2024 (UTC)
- Yes, they are very similarly named, and I think I got confused. Especially if it's just inside the Tooltip, I agree with Tollens that probably hardly anybody will even notice. Mathglot (talk) 20:31, 4 March 2024 (UTC)
- Parsing is working in the subtemplate sandbox; next is further testing and moving the subtemplate sandbox to live, deciding what wording you want, then we have to add the wording to the Talk header sandbox, add new test cases for it, and then move the new TPH sandbox to live. After that, similar for Template:Archives: new wording (not a tooltip), then sandbox and test it, and release to live. Both templates use the same parser. The blocking dependency now is deciding on the wording for Template:Talk header, presumably in the tooltip. Mathglot (talk) 02:35, 20 March 2024 (UTC)
- I'd support CapnZapp's suggested "if more than X thread(s) is/are eligible for archiving" appended to the end of the existing tooltip. Tollens (talk) 02:58, 20 March 2024 (UTC)
- How about: "If X or more threads are eligible for archiving"; that will save having to add code for verb number agreement. Also, I think we should only generate it when X >= 2. When X=1, adding the phrase or not adding it describe identical constraints, so the X=1 case doesn't need to be shown, and it might even make it worse as viewers would probably have to pause and try to parse out what it means. Mathglot (talk) 05:38, 23 March 2024 (UTC)
- Oh, right, of course – I forgot that archiving was when there were ≥ the number specified in the parameter, not >. Your wording looks good to me. Tollens (talk) 06:10, 23 March 2024 (UTC)
- Only saying something when
|minthreadstoarchive=2
(or more) was part of my original proposal, so, yeah. CapnZapp (talk) 17:31, 26 March 2024 (UTC)
- Only saying something when
- Oh, right, of course – I forgot that archiving was when there were ≥ the number specified in the parameter, not >. Your wording looks good to me. Tollens (talk) 06:10, 23 March 2024 (UTC)
- How about: "If X or more threads are eligible for archiving"; that will save having to add code for verb number agreement. Also, I think we should only generate it when X >= 2. When X=1, adding the phrase or not adding it describe identical constraints, so the X=1 case doesn't need to be shown, and it might even make it worse as viewers would probably have to pause and try to parse out what it means. Mathglot (talk) 05:38, 23 March 2024 (UTC)
- I'd support CapnZapp's suggested "if more than X thread(s) is/are eligible for archiving" appended to the end of the existing tooltip. Tollens (talk) 02:58, 20 March 2024 (UTC)
- Parsing is working in the subtemplate sandbox; next is further testing and moving the subtemplate sandbox to live, deciding what wording you want, then we have to add the wording to the Talk header sandbox, add new test cases for it, and then move the new TPH sandbox to live. After that, similar for Template:Archives: new wording (not a tooltip), then sandbox and test it, and release to live. Both templates use the same parser. The blocking dependency now is deciding on the wording for Template:Talk header, presumably in the tooltip. Mathglot (talk) 02:35, 20 March 2024 (UTC)
- I think CapnZapp is referring to a completely different thing than Mathglot and Sdkb here. There are two different parameters that relate to a number of threads – one (the one currently displayed) is for the number of threads which have to remain on the page after archiving (for example, if this parameter was 2 and there were 5 threads on the page, all of them old enough to archive, only 3 threads would be archived). The other one, which I think CapnZapp is referring to, is for the minimum number of threads that are allowed to be archived with a single edit by the bot (as another example, if that parameter was 2 and there was exactly one thread old enough to archive, the bot would not archive it at all, but once there were 2 or more eligible threads the bot would archive them all). Tollens (talk) 10:07, 4 March 2024 (UTC)
Testing progress
This is developed and now in test mode. I tweaked the wording slightly which seemed to flow better. Here's a summary of status and pages involved:
- Functionality – description of requested change (in this section, above)
- Archive bot config parser sandbox – now parses minarchthreads/minthreadstoarchive
- Template:Talk header/sandbox – points to parser sandbox, and has new tooltip code added for minarchthreads/minthreadstoarchive
- Testcases, tab 4 – pre-existing and new tests for archiving notice functionality
- test cases for Talk pages having a Miszabot config – no testcases yet; t.b.a.
- test cases for Talk pages having a Cluebot config – (twelve tests in place, passing).
More eyeballs and more tests are needed; this is needless to say a highly visible template and we need to test the new functionality, as well as regression to ensure nothing is broken before going live. I need to set this aside for a while, so any help appreciated. Add tests directly to the test page {{Talk header/testcases4}}, and please examine or run regression tests on the first three testcase pages as well; please note what works/doesn't below. Doc on page testcases4 is still thin; feel free to adjust as needed, and if there is anything inscrutable, please lmk. Mathglot (talk) 02:10, 29 March 2024 (UTC)
- Just added the tests on tab 4 for talk pages with a Miszabot config, and they all seem to be passing with the version in the sandbox. Looking through tabs 1 and 3, everything appears fine (tab 2 is now completely redundant and could/should probably be deleted). The one thing I did notice that is not really as expected is that when the number of threads to keep on the page is 1, the grammar is wrong (see Talk:Conspiracy theory), and when it's 0, there shouldn't be a message at all but there is (see Talk:Cold fusion) – I should be able to fix both pretty easily. Tollens (talk) 01:14, 30 March 2024 (UTC)
- That fix is now done. Tollens (talk) 01:26, 30 March 2024 (UTC)
- Edit-conflicted with you, so my test is invalid as I don't know if it took place after your fix, but the first part of the message was this:
- Oh, that's great; thanks for the testcases update, glad they worked. As far as minthreads and the two Talk pages, that could mean the legacy code was doing that, as the minthreads stuff is old code and was not changed for this upgrade (although the conditional logic around it was). Looking at legacy rev. 1193759647, there is no adjustment for sing/plural; not sure if it handled the number of threads correctly or not at that point. But I am not seeing what you do: in both test methods, I see these results for Cold fusion:
- CF live: Discussions with timestamps are automatically archived by lowercase sigmabot III after 180 days of inactivity when more than 0 threads are present.
- CF sbox: Discussions with timestamps are automatically archived by lowercase sigmabot III after 180 days of inactivity.
- Post-ec again: that sandbox test of mine could've been run after your fix, so that is meaningless; but the live test showed that problem before; anyway, good that you've fixed that. I've maybe missed something from your message, as I feel I have two many balls in the air; did I? Mathglot (talk) 01:51, 30 March 2024 (UTC)
- If that was the result you got, you definitely ran that test after it was fixed in the sandbox, it wouldn't have worked before this change. It was certainly the old version that was broken, I agree nothing that's been done related to this changed it. I don't think you've missed anything. Tollens (talk) 01:58, 30 March 2024 (UTC)
- That fix is now done. Tollens (talk) 01:26, 30 March 2024 (UTC)
Was just poking around your new test cases, and found a new one at Talk:Hurricane Florence with minthreadstoarchive=7. It doesn't test the new code path, because the config defines the archive names as using the date style, and {{Talk header}} doesn't display anything for that case. But, we still have access to all the config params and if we wanted, we *could* still display the bot notice in that case, maybe even in plain text not as a tooltip, as a way for Talk header to display *something* even if it can't show the links. For that matter, it wouldn't be that hard to reconstitute the actual archive names based on parsing the |Archive=
param, but this is sounding more and more like a new proposal and off-topic with what we are testing here, so I think I'll drop this for now. I just wanted to get that out there, before I forgot about it, so we can take it up again if we want later after the dust has settled on current stuff. Mathglot (talk) 02:15, 30 March 2024 (UTC)
Just to chime in regarding the cutoff for rounding ClueBot: it appears the code is using 24 hours. Only User:Novem Linguae suggested this. I have suggested 72 hours instead. Nobody has objected, but also, your response so far has been "it's incredibly easy to change it to any figure that comes out of consensus here" which is nice, but also kind of ignores my message. How about doing that which is so incredibly easy, and setting the number to 72 before finalizing testing, and then waiting for consensus to change it? CapnZapp (talk) 21:27, 4 April 2024 (UTC)
Note: the test code in the sandbox for adding this functionality has been removed in order to attend to a more important issue (see § Broken case below). The change will need to be re-added and retested in the sandbox. before moving ahead. Mathglot (talk) 06:15, 14 April 2024 (UTC)
Broken case
Talk:Nothing is producing an expression error, something about a comma somehow getting into an expression (originally posted at User talk:ClueBot III/ArchiveThis § Nothing is wrong). Aidan9382 (talk) 17:11, 3 April 2024 (UTC)
- Bad timing for me to look at this, as I'll be away for a couple of weeks; revert last change if you think it's needed. The locus of the problem is the rounding of the hours-to-days conversion for Cluebot age values > 24 in the parser subtemplate {{Talk header/archivebotparse}}. Here are some tests that show this:
content of the Cluebot config at Talk:Nothing
|
---|
{{User:ClueBot III/ArchiveThis |archiveprefix=Talk:Nothing/Archive |format= %%i |age=15000 |maxarchsize=150000 |numberstart=2 |archivebox=yes |box-advert=yes }} |
Test archive bot parser for Talk:Nothing page via ExpandTemplates
| ||||
---|---|---|---|---|
Set Context title to Test [[Template:Talk header/archivebotparse]]: * bot: {{Template:Talk header/archivebotparse|bot}} * age: {{Template:Talk header/archivebotparse|age}} * age (aliased): {{Th/abp|age}} * age rounded-a: {{Th/abp|age|round=y}} * age rounded-b: {{Th/abp|age|r=y}} * units: {{Template:Talk header/archivebotparse|units}} * minkeepthreads {{Template:Talk header/archivebotparse|minkeepthreads}}
|
- The ExpandTemplates test fails rounding the quotient of 15000/24. It's interesting that it doesn't fail when invoking the parser without
|round=y
. So I suspect the problem is somewhere in here;
Parser code snippet to investigate
|
---|
|age = {{#if: {{{round|{{{r|}}}}}} | {{#ifexpr: {{tmpv|{{{2|{{FULLPAGENAME}}}}}|User:ClueBot III/ArchiveThis|1|age}} > 24<!-- --> | {{#expr: {{round|2*{{#expr: {{tmpv|{{{2|{{FULLPAGENAME}}}}}|User:ClueBot III/ArchiveThis|1|age}} / 24}}|0}} / 2}} <!-- --> | {{tmpv|{{{2|{{FULLPAGENAME}}}}}|User:ClueBot III/ArchiveThis|1|age}} <!-- --> }} <!-- -->| {{tmpv|{{{2|{{FULLPAGENAME}}}}}|User:ClueBot III/ArchiveThis|1|age}} <!-- -->}} |
- Sorry about the timing; if this isn't enough to narrow it down sufficiently to lead to a solution, feel free to revert. Also, this points to additional test cases for the parser subtemplate that should be added to Template:Talk header/testcases4. I might be able to look at this one more time before I'm away to answer questions if something isn't clear. Mathglot (talk) 00:12, 4 April 2024 (UTC)
- Found myself with some time this morning so I've tried to look into and fix the issue myself. Seems to be an issue with {{Round}} giving back comma-formatted numbers. I've fixed that in this change. Aidan9382 (talk) 08:06, 4 April 2024 (UTC)
- Tyvm. Mathglot (talk) 08:26, 4 April 2024 (UTC)
- Found myself with some time this morning so I've tried to look into and fix the issue myself. Seems to be an issue with {{Round}} giving back comma-formatted numbers. I've fixed that in this change. Aidan9382 (talk) 08:06, 4 April 2024 (UTC)